@rmobis @Andre-Gl can you please verify this works with webpack v1? Thanks.

@Judahmeek, could you maybe try this out?

Yes, I'll try it out.

We're really looking forward to seeing this in. Alpha2 is broken in multiple ways for us that alpha4 fixes

@Judahmeek @outdooricon I can't finish this for at least a week. Can one of you guys submit a new PR with this, fixing the things that are broken.

thanks!

@justin808 I'll give it a shot.

@justin808 All the errors were due to the fact that the examples have their own modules of bootstrap-loader instead of being linked to local code. Is there a particular reason for that or can I attempt to create a local dependency with symlinks to the local source code?

Also, the examples' webpack.configs need to be updated on line 56/57 (just removing the /umd\).

@Judahmeek

https://github.com/shakacode/bootstrap-loader/tree/v1/examples/basic

See the line

npm run install-local

We can hard code the values in the file, but they need to be changed every release.

Maybe we just need to change the docs? on this page.

We can probably just put this down to my inexperience as a contributor. I overlooked the README, went straight to package.json, and overlooked npm install-local there because I wasn't considering the need for the examples to be used as integration tests (and thus the need for some form of linking).

Hey, Any update on this ? :)

I just merged this to the V1 branch as is. There might be a couple more changes and then a release for v1.

Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

Review status: 0 of 9 files reviewed at latest revision, 2 unresolved discussions.

src/utils/createBootstrapRequire.js, line 15 at r2 (raw file):

I'll update this.

module: {
  loaders: [
    // Use one of these to serve jQuery for Bootstrap scripts:

    // Bootstrap 3
    { test:/bootstrap-sass[\/\\]assets[\/\\]javascripts[\/\\]/, loader: 'imports?jQuery=jquery' },

    // Bootstrap 4
    { test: /bootstrap[\/\\]dist[\/\\]js[\/\\]umd[\/\\]/, loader: 'imports?jQuery=jquery' },
  ],
},

Comments from Reviewable

@outdooricon @frickt @igama @rmobis @Andre-Gl:

Released 1.2 with support for alpha.v4!

@justin808 sweet, thanks!